Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@
lineItem.quantities = {};
}
lineItem.quantities[column.name] = {};
if (lineItem[column.name]) {
if (lineItem[column.name] !== null && lineItem[column.name] !== undefined) {
lineItem.quantities[column.name].quantity = lineItem[column.name];
lineItem.quantities[column.name] = quantityUnitCalculateService.
recalculateInputQuantity(lineItem.quantities[column.name],
Expand Down
44 changes: 44 additions & 0 deletions src/requisition-view-tab/requisition-view-tab.controller.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@
set: function() {},
get: function() {}
});
$provide.value('quantityUnitCalculateService', {
recalculateInputQuantity: jasmine.createSpy('recalculateInputQuantity')
.andCallFake(function(item) {
return item;
})
});
});

var RequisitionLineItemDataBuilder, RequisitionDataBuilder, RequisitionColumnDataBuilder, OrderableDataBuilder;
Expand Down Expand Up @@ -454,6 +460,44 @@

});

describe('quantities initialization', function() {

it('should populate quantities with zero value from line item', function() {
var RequisitionColumnDataBuilder;

Check failure on line 466 in src/requisition-view-tab/requisition-view-tab.controller.spec.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Unexpected var, use let or const instead.

See more on https://sonarcloud.io/project/issues?id=OpenLMIS_openlmis-requisition-ui&issues=AZ68-DsZixFPtcnbzNEg&open=AZ68-DsZixFPtcnbzNEg&pullRequest=81
inject(function($injector) {
RequisitionColumnDataBuilder = $injector.get('RequisitionColumnDataBuilder');
});

var column = new RequisitionColumnDataBuilder()

Check failure on line 471 in src/requisition-view-tab/requisition-view-tab.controller.spec.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Unexpected var, use let or const instead.

See more on https://sonarcloud.io/project/issues?id=OpenLMIS_openlmis-requisition-ui&issues=AZ68-DsZixFPtcnbzNEh&open=AZ68-DsZixFPtcnbzNEh&pullRequest=81

Check warning on line 471 in src/requisition-view-tab/requisition-view-tab.controller.spec.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Replace RequisitionColumnDataBuilder with a constructor function.

See more on https://sonarcloud.io/project/issues?id=OpenLMIS_openlmis-requisition-ui&issues=AZ68-DsZixFPtcnbzNEi&open=AZ68-DsZixFPtcnbzNEi&pullRequest=81
.buildRequestedQuantityColumn(this.requisition);
var lineItem = {

Check failure on line 473 in src/requisition-view-tab/requisition-view-tab.controller.spec.js

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Unexpected var, use let or const instead.

See more on https://sonarcloud.io/project/issues?id=OpenLMIS_openlmis-requisition-ui&issues=AZ68-DsZixFPtcnbzNEj&open=AZ68-DsZixFPtcnbzNEj&pullRequest=81
requestedQuantity: 0,
orderable: {
netContent: 10
},
updateFieldValue: jasmine.createSpy('updateFieldValue')
};

this.vm = this.$controller('ViewTabController', {
lineItems: [lineItem],
items: [lineItem],
columns: [column],
requisition: this.requisition,
canSubmit: this.canSubmit,
canAuthorize: this.canAuthorize,
fullSupply: this.fullSupply,
program: {},
$scope: this.$scope,
canApproveAndReject: this.canApproveAndReject,
canUnskipRequisitionItemWhenApproving: this.canUnskipRequisitionItemWhenApproving
});
this.vm.$onInit();

expect(lineItem.quantities['requestedQuantity'].quantity).toBe(0);
});

});

});

describe('deleteLineItem', function() {
Expand Down
Loading