Skip to content

OLMIS-8177: Remove unused validation class binding #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaldev0 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OLMIS-8177: Remove unused validation class binding #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
7.0.18-SNAPSHOT (WIP)
==================

Bug fixes:
* [OLMIS-8177](https://openlmis.atlassian.net/browse/OLMIS-8177): Removed a dead validation class binding from the requisition product grid packs/doses quantity input.

7.0.17 / 2026-06-09
==================
Bug fixes:
Expand Down
3 changes: 1 addition & 2 deletions src/requisition-product-grid/product-grid-cell-input-numeric.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
<input positive-integer
ng-if="!column.isQuantityColumn()"
ng-model="lineItem[column.name]"
ng-disabled="lineItem.skipped"
ng-change="update()"/>

Check warning on line 5 in src/requisition-product-grid/product-grid-cell-input-numeric.html

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Add an "id" attribute to this input field and associate it with a label. 


See more on https://sonarcloud.io/project/issues?id=OpenLMIS_openlmis-requisition-ui&issues=AZ7SZuLzcgLJX1X505uh&open=AZ7SZuLzcgLJX1X505uh&pullRequest=83
<openlmis-quantity-unit-input
ng-if="column.isQuantityColumn()"
disabled="lineItem.skipped"
show-in-doses="showInDoses()"
item="lineItem.quantities[column.name]"
net-content="lineItem.orderable.netContent"
on-change-quantity="update()"
input-class="{'error': lineItem.quantityInvalid}"/>
on-change-quantity="update()"/>
Loading