Conversation
create MongoDBConfig class Created tests for MongoDBConfig class, all tests pass
…er doesn't initialize
# Conflicts: # jmaqs-utilities/src/main/java/com/magenic/jmaqs/utilities/helper/TestCategories.java # pom.xml
formatting
# Conflicts: # pom.xml
new MAQS naming updates
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| */ | ||
| public static MongoCollection<Document> getCollection( | ||
| String connectionString, String databaseString, String collectionString) { | ||
| try (MongoClient mongoClient = create(connectionString)) { |
There was a problem hiding this comment.
BadImport: Importing nested classes/static methods/static fields with commonly-used names can make code harder to read, because it may not be clear from the context exactly which type is being referred to. Qualifying the name with that of the containing class can make the code clearer. Here we recommend using qualified class: MongoClients.
| try (MongoClient mongoClient = create(connectionString)) { | |
| try (MongoClient mongoClient = MongoClients.create(connectionString)) { |
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| * {@inheritDoc} | ||
| */ | ||
| public void overrideMongoDBDriver(String connectionString, String databaseString, String collectionString) { | ||
| this.getMongoDBManager().overrideDriver(connectionString, databaseString, collectionString); |
There was a problem hiding this comment.
RESOURCE_LEAK: resource of type io.github.openmaqs.nosql.MongoDBDriver acquired by call to overrideDriver(...) at line 51 is not released after line 51.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| */ | ||
| @Override | ||
| public void overrideMongoDBDriver(Supplier<MongoCollection<Document>> overrideCollectionConnection) { | ||
| this.getMongoDBManager().overrideDriver(overrideCollectionConnection); |
There was a problem hiding this comment.
RESOURCE_LEAK: resource of type io.github.openmaqs.nosql.MongoDBDriver acquired by call to overrideDriver(...) at line 67 is not released after line 67.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/OpenMAQS/openmaqs-java/26.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/OpenMAQS/openmaqs-java/26.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes |
2 participants
No description provided.