CMake that is still supported #36
Conversation
… cmake_minimum_required These were already NEW because the OSG already uses 2.8
CMP0012 to CMP0023 do not look relevant to this one file.
Introduced by 7195e59
This now-illegal macro doesn't seem to be used anywhere
It was only used to check OSG's minimum version anyway.
It seems to be a hallucinated way to check the current CMake version - it's not mentioned even in old versions of the docs - but LLMs wouldn't be invented for well over a decade.
Spaces are illegal in target names (although legal in labels - it's not worth setting that up here, though)
All policies up to CMP0050 have been verified compatible (after far more tweaking than I'd have liked)
I've verified all the policies up to CMP0056
I didn't notice that the condition was inverted so this code had become unreachable rather than unavoidable.
This one definitely broke OpenMW when we bumped our minimum CMake version past 3.5, but that meant that we already knew about it and already knew how to fix it and which platforms were affected.
|
I believe we've got this to where it needs to be, at least until CMake drop support for versions below 3.10 within the next few months/years. |
|
LGTM |
|
The test branch I pushed to confirm that this resolved the FFMPEG CMake issue with vcpkg finished building, so we've done all the testing we can do other than put dev builds in the hands of users and see if we get bug reports. |
The approval button is in the Files changed tab. |
Well, doesn't really matter, does it? Just a formality. No approval requirement set up here. 😛 |
|
The machine-enforced version of the policy isn't quite the real policy on any of our repos. Anyway, the main thing is that approvals show up in the approval total, but LGTM comments don't, so they're harder to find. If we go with the standard OpenMW rules, we're waiting for:
|
3 participants
So far, I've got to CMake 3.0, and the bump from 2.8 to 3.0 was bigger than 3.0 to 3.5, so going all the way to 3.5 hopefully will be something I can do in one sitting.