[com1] Add cfg override folder / expert configuration #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
❌ 1 blocking issue (5 total)
@qltysh one-click actions:
|
Contributor
|
Coverage Impact ⬇️ Merging this pull request will decrease total coverage on Modified Components (1)
Modified Files with Diff Coverage (10)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
awirb
requested changes
Jan 27, 2026
…verride` keyword argument - Updated all `cfgUtils.getModuleConfig` calls to use the explicit `fileOverride` parameter
… calls - Updated all instances of `cfgUtils.getModuleConfig` to include the `avalancheDir` parameter
…NotInOverride` functions along with associated tests
fso42
force-pushed
the
overrideFolder2
branch
from
c67d2d3 to
22e34cb
Compare
awirb
requested changes
Jan 30, 2026
awirb
approved these changes
Feb 3, 2026
…o` parameters from `getModuleConfig` calls
- Cleaned up calls to `cfgUtils.getModuleConfig` by removing redundant `fileOverride` and `modInfo` arguments across multiple scripts and modules.
- Addressed AW comments
fix(com1DFA): update module exclusion condition in `getModuleNames`
- Adjusted logic to exclude all modules under the `com1DFA` package using `startswith("avaframe.com1DFA")` instead of an exact match
…plify config handling - Removed `checkCfgInfoType` from `com1DFATools.py` and related calls across `com1DFA` modules. - Replaced redundant type checks with direct handling of `cfgInfo` as `ConfigParser`, `Path`, or string. - Extennd `getModuleConfig to support `batchCfgDir` for directory-based batch processing. - Updated related tests refactor(tests, com1DFA,com3): simplify config handling and improve simulation calls - Replaced redundant `fileOverride` usage in test configurations with direct `cfg` handling. - Updated multiple test scripts to streamline `com1DFAMain` calls - Adjusted hybrid module to directly modify config values, removing `ConfigUpdater` dependency. refactor(com1DFA): improve code readability and fix logging messages; comments AW - Introduced a deep copy for `com1DFA` configuration to prevent unintended mutations - `getModuleConfig` priority documentation and logic handling - Added warning for ignored friction calibration in expert mode
fso42
force-pushed
the
overrideFolder2
branch
from
74f59cf to
75c58e5
Compare
Contributor
Author
|
Standardtests ident |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
over local config files
avalancheDir arguments
Documentation update follows in a separate PR.