[in3,com8,ana3] Add multi-layer result support; breaking change in com8 #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t in filename parsing and data handling - `fileHandlerUtils.makeSimFromResDF` handle multi-layer result files with layer-suffixed column names. - Updated `cfgUtils.parseSimName` to recognize and parse layer components (`L1`, `L2`, etc.) in filenames.
…g logic - Introduced `layers` configuration for specifying simulation output layers (L1: dense flow, L2: powder snow). - Added `copyRawToLayerPeakFiles` function
- Introduced `runoutLayer` configuration for multi-layer analysis in `ana3AIMECCfg.ini`. - Updated `checkAIMECinputs` to resolve base resType names to layer-suffixed columns. - Refactored functions and logic to error out if multi-layer data is detected without a `runoutLayer`.
fso42
changed the title
Contributor
❌ 2 blocking issues (4 total)
@qltysh one-click actions:
|
fso42
changed the title
Contributor
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (6)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| c=cmap3.to_rgba(cmapVal), | ||
| label=resAnalysisRow[varParList[0]], | ||
| ) | ||
| else: |
Contributor
| baseRunoutResType = inputs.get('baseRunoutResType', runoutResType) | ||
| displayRunoutResType = inputs.get('displayRunoutResType', runoutResType) | ||
| unit = pU.cfgPlotUtils['unit' + baseRunoutResType] | ||
| name = pU.cfgPlotUtils['name' + baseRunoutResType] |
Contributor
- Added support for resolving base `resType` to layer-suffixed columns in multi-layer simulations using the new `resolveResTypeColumn` function. - Introduced `computeBaseResTypeList` to validate and compute base `resType` names available for all simulations. - Updated `checkAIMECinputs` function to handle both single-layer and multi-layer simulations, with input validation and error handling when `runoutLayer` is not configured.
| continue | ||
| outAimec.plotMaxValuesComp(pathDict, resAnalysisDF, compResType, compResType2, | ||
| hue=cfgPlots['scenarioName']) | ||
|
|
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change:
com8MoTPSA output filenames changed. Previously they used the dfa/psa modelType workaround, now they use L1/L2
layer naming. Anyone with existing com8MoTPSA results or scripts that parse the old filenames will be affected.