Enhance ArrayUtils.reconstruct with Flat Output Support#23
Merged
afshawnlotfi merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
…arrays; update README and tests for clarity on usage and expected behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR enhances the
ArrayUtils.reconstructmethod in both Python and TypeScript to support returning flat 1-D arrays, providing more flexibility for different use cases like GPU buffer consumption.Key Changes
Core Feature:
flatParameterflat: bool = Falseparameter toArrayUtils.reconstruct()in both Python and TypeScriptflat=True: Returns a single flatTypedArray/ndarray(useful for GPU vertex buffers)flat=False(default): 2-D+ arrays are split into per-columnTypedArray[]in TypeScript, or reshaped to original dimensions in PythonTypeScript (
typescript/src/array.ts)reconstruct()to reduce code duplication across encoding branchesTypedArray | TypedArray[][N, stride]now return an array ofstridecolumn arrays by defaultPython (
python/meshly/array.py)flatparameter with docstring explaining behaviorMesh Decoding
Mesh.decode()explicitly passesflat=trueto always return flat arrays (mesh data is consumed as interleaved GPU buffers)PackableWorkerClient.decodeArray()also usesflat=trueTest Updates
TypedArray[]for 2-D fields likeinertia_tensorandcollision_pointsDocumentation
Mesh.decodealways returns flat arraysflatparameter