Security Limits & Decoder API Enhancement#1
Merged
afshawnlotfi merged 2 commits intomasterfrom Feb 27, 2026
Merged
Conversation
- Implement validation methods for vertex and index parameters to prevent memory exhaustion and ensure valid inputs. - Integrate MeshoptLimits in encoder and decoder functions to enforce limits during encoding and decoding processes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces security-focused parameter validation and enhances the vertex buffer decoding API for better flexibility and type safety.
Changes
1. Security Limits (
MeshoptLimitsclass)New limits.py module providing configurable security limits to prevent DoS attacks via memory exhaustion:
Configurable Limits:
MAX_TOTAL_BYTESMAX_VERTEX_SIZEMAX_VERTEX_COUNTMAX_INDEX_COUNTValidation Methods:
validate_vertex_params()- Validates vertex count, vertex size, alignment (must be multiple of 4), and total allocationvalidate_index_params()- Validates index count and index size (must be 2 or 4)All encoder/decoder functions now validate parameters before memory allocation.
2. Enhanced
decode_vertex_buffer()APIAdded optional
dtypeparameter for direct decoding to custom numpy dtypes:This consolidates the previous
decode_vertex_buffer_raw()function into the main API, reducing code duplication while maintaining backward compatibility.Version
0.2.20a5→0.2.30a