mctp: Bump mctp-lib to branch main - #461
Open
EvanChuchen731 wants to merge 1 commit into
Open
EvanChuchen731 wants to merge 1 commit into
EvanChuchen731 wants to merge 1 commit into
Conversation
EvanChuchen731
requested review from
CourtneyDrant,
JesseMelon and
rusty1968
September 9, 2026 09:18
Collaborator
|
Resolve conflicts. |
Collaborator
EvanChuchen731
force-pushed
the
mctp-lib-main
branch
from
September 16, 2026 03:50
79d0b6e to
0b53703
Compare
Author
|
@wmaroneAMD The merge conflicts have been resolved. Please kindly review the changes when you have a moment. Thanks! |
The pinned 9e-buildup branch does not carry the mctp_control module, which provides the datatypes and the MctpCodec trait for encoding and decoding DSP0236 control-protocol messages. Branch main carries it, so a control-protocol responder can be built against this dependency. Branch main also accepts a packet addressed to EID 0, which 9e-buildup dropped whenever this endpoint had another EID. An endpoint answers on EID 0 until a bus owner assigns it one, so that drop left Set Endpoint ID unanswerable. Two API changes come with the branch. Sender::send_vectored takes the destination EID ahead of the fragmenter, which the one production sender and the five test mocks now accept and ignore: the production sender routes to the single peer address fixed at construction, and each mock captures or discards every packet. Router::inbound returns the cookie of the handle a matched message was queued for, or None for a discarded one, and Server::inbound drops that value, since Server::update reaches the message by polling each outstanding handle by cookie. The mctp pin moves from a floating branch to the rev mctp-lib main itself pins, so one mctp version resolves for both. Signed-off-by: Evan Chuchen <evan_chuchen@jabil.com>
EvanChuchen731
force-pushed
the
mctp-lib-main
branch
from
September 21, 2026 07:26
0b53703 to
5d0aff2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mctp-libis pinned to9e-buildup, which does not carry themctp_controlmodule. That module provides the datatypes and theMctpCodectrait for encoding and decoding DSP0236 control-protocolmessages, so this repo cannot build a control-protocol responder against
the pinned branch.
Branch
mainalso accepts a packet addressed to EID 0, which9e-buildupdropped whenever this endpoint had another EID. An endpointanswers on EID 0 until a bus owner assigns it one, so that drop left Set
Endpoint ID unanswerable.
What changes
Branch
mainalters two APIs this repo calls, and the source changeshere are the call sites those two alterations reach:
Sender::send_vectorednow takes the destination EID ahead of thefragmenter. The one production sender and the five test mocks accept
and ignore it:
I2cSenderwrites to the single peer address fixed atconstruction, and each mock captures or discards every packet.
Router::inboundnow returnsOption<AppCookie>, the cookie of thehandle a matched message was queued for.
Server::inbounddrops thatvalue, since
Server::updatereaches the message by polling eachoutstanding handle by cookie.
The
mctppin also moves from a floating branch to the revmctp-libmainitself pins, so onemctpversion resolves for both.The two lockfiles are regenerated rather than hand-edited: bazel runs
--lockfile_mode=updateby default and this repo sets no override, soediting the crate manifests re-evaluates the
rust_cratesextension. Bothdeltas carry
mctpandmctp-libentries alone.Testing
bazel test //services/mctp:mctp_host_testsplus the four pldm hosttests: 10 of 10 passing
bazel build --config=k_ast1060_evb //target/ast10x0/...: 405 targets,completed successfully
//services/mctp/...and//services/pldm/...:no findings
./pw format --checkover the five edited Rust files and the manifest:no changes needed