orchestrator: Rename signal/G to probe/P in boot checkpoints - #475
Merged
Merged
Conversation
The generic was called G ("signal") when it only described GPIO-ready
lines. Real boards also poll progress registers, MCTP readiness and
heartbeat latches, so the narrower name was misleading. P ("probe")
covers every kind of health indicator the evidence reader can sample.
Renames: BootCheckpoint<G> to <P>, signal field/accessor to probe,
EvidenceReader<G> to <P>, fn read(signal:) to fn read(probe:),
MockSignal to MockProbe, and all doc references. Adds a GPIO wiring
example to BootCheckpoint's doc comment.
Assisted-by: Claude
chrysh
marked this pull request as draft
September 21, 2026 15:51
chrysh
marked this pull request as ready for review
September 21, 2026 15:56
mynetz
self-requested a review
September 21, 2026 16:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
G/signal toP/probe inBootCheckpoint,EvidenceReader, and the mock board'sMockSignaltoMockProbe.The old name implied GPIO-only, but real boards also poll MCTP readiness,
progress registers and heartbeat latches.
BootCheckpoint's doc comment. The examplereferences
CheckpointWalk, added in orchestrator: Add CheckpointWalk, the concrete BootWatch #471.Pure rename, no behavioral change. 3 files touched.