ast10x0/harness: reap orphaned pi_test_runner processes holding the UARTs - #476
Open
JesseMelon wants to merge 1 commit into
Open
JesseMelon wants to merge 1 commit into
JesseMelon wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
pi_test_runner.pyon the Pi does not die when its SSH client drops (e.g. Ctrl-Con the host). The orphan keeps
/dev/ttyUSB*open, which silently swallows thebootloader handshake of every subsequent run — the next test simply fails to flash,
with no clear indication why.
Reap stale runners at both ends of
_run_remote: once after the lock is acquired andagain in the cleanup path. Because the reap only runs while holding the lock, any
match is by definition an orphan. A one-second sleep lets the kernel release the
serial ports before they are reopened.