pldm-common: add the UpdateSecurityRevision message - #22
Merged
Merged
Conversation
Adds command 0x22 and its request and response structs, DSP0267 1.3.0 section 12.19. The UA sends it after a transfer that set the Security Revision Number Delayed Update option, to commit the revision once the new image has run; until then a downgrade is still allowed. Message layer only. The FD dispatch needs a new FdOps callback, so the trait change and its wiring are a follow-up. Assisted-by: Claude
chrysh
marked this pull request as ready for review
September 14, 2026 18:55
CourtneyDrant
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds PLDM command 0x22,
UpdateSecurityRevision, from DSP0267 1.3.0section 12.19, Table 47.
The UA sets the Security Revision Number Delayed Update option
(
UpdateOptionFlagsbit 2) onUpdateComponentso the FD applies andactivates an image without raising the security revision. The image then
runs at the old floor and a downgrade is still allowed, which is the window
the UA uses to test it.
UpdateSecurityRevisioncloses that window. The FDtakes it in the IDLE state, outside update mode, and it acts on the active
running image, not a pending one.
The supporting pieces were already in the tree and are untouched:
UpdateOptionFlags::svn_delayed_update,FirmwareDeviceCapability::svn_update_support, and theUpdateSecurityRevisionNotPermitted(0x95) completion code.Scope
Message layer only: the two structs, the command code, and round-trip
tests. FD dispatch needs a new
FdOpscallback to commit the revision, sothe trait change and its wiring are a follow-up PR.
Tests
cargo test --all-features --workspacepasses, 100 tests. Four are new:request and response round trips, the downstream-device form
(classification
0xFFFF, index0xFF), and a short-buffer rejection onboth encode and decode.
Assisted-by: Claude