Skip to content

Simplify translation_check.py to dump once per language - #3303

Merged
tupaschoal merged 1 commit into
OpenRCT2:masterfrom
tupaschoal:improve_check
Aug 9, 2025
Merged

Simplify translation_check.py to dump once per language#3303
tupaschoal merged 1 commit into
OpenRCT2:masterfrom
tupaschoal:improve_check

Conversation

@tupaschoal

Copy link
Copy Markdown
Member

This prints the summary for each language only once, which makes it easier for maintainers to check what they need to do and should greatly reduce the size of the CI job log

@github-actions

github-actions Bot commented Aug 9, 2025

Copy link
Copy Markdown

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 277 2 1728
ca-ES 18 0 91
cs-CZ 0 0 150
da-DK 13 1 324
de-DE 11 0 147
en-US 3453 0 1
eo-ZZ 2 0 72
es-ES 8 0 166
fi-FI 97 1 95
fr-CA 3618 0 0
fr-FR 2 0 144
gl-ES 2 1 94
hu-HU 0 1 95
it-IT 20 0 138
ja-JP 97 1 121
ko-KR 0 0 95
nb-NO 186 1 162
nl-NL 11 0 184
pl-PL 60 0 99
pt-BR 0 0 142
ru-RU 0 0 118
sv-SE 8 1 161
tr-TR 515 1 98
uk-UA 181 34 719
vi-VN 25 0 117
zh-CN 8 0 36
zh-TW 44 0 115

@tupaschoal

Copy link
Copy Markdown
Member Author

For reference, here are two runs with and without PR
log_with_PR.txt: 290KB, 298 lines
log_without_PR.txt: 1058KB, 14256 lines

@tupaschoal
tupaschoal merged commit fe6dae3 into OpenRCT2:master Aug 9, 2025
1 check passed
@tupaschoal
tupaschoal deleted the improve_check branch August 9, 2025 10:08
rmnvgr pushed a commit to rmnvgr/Localisation that referenced this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant