fix: fix both pause/unpause and step into with lots of tests#1969
Merged
maximilien-noal merged 2 commits intofix/pause_unpause_notiffrom Mar 14, 2026
Merged
fix: fix both pause/unpause and step into with lots of tests#1969maximilien-noal merged 2 commits intofix/pause_unpause_notiffrom
maximilien-noal merged 2 commits intofix/pause_unpause_notiffrom
Conversation
Co-authored-by: maximilien-noal <1087524+maximilien-noal@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix pause/unpause state synchronization
fix: fix both pause/unpause and step into with lots of tests
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes stale pause/unpause state between UI and Core, and replaces non-monotonic
DateTime.UtcNowtimeout measurement in test polling helpers withStopwatch.Description of Changes
DisassemblyView.axaml.cs: Track visual-tree attachment state; activate/deactivate view model onDataContextChangedto handle attach-before-DataContext lifecycle ordering.StepOverAsmUiTests.cs/StepIntoAsmUiTests.cs: ReplaceDateTime.UtcNowwithStopwatchinWaitUntilpolling helpers for monotonic elapsed-time measurement.DisassemblyViewUiTests.cs: Regression test for attach-before-DataContext ordering and pause event propagation; uses runtime null guard instead of null-forgiving operator on reflected method.Rationale behind Changes
DisassemblyViewcould be attached to the visual tree before itsDataContextis set, leavingDisassemblyViewModelnever activated and the disassembly panel unresponsive to pause events.DateTime.UtcNowin test timeout loops is susceptible to NTP/clock adjustments causing spurious timeouts;Stopwatchis monotonic.Suggested Testing Steps
Run the UI headless tests — they cover the attach-before-DataContext ordering and step-into/step-over pause state transitions. The original race condition is non-deterministic and difficult to reproduce manually.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.