#79 Multi-object launches with several options. Solenoid test case. - #84
Open
lmdiazangulo wants to merge 10 commits into
Open
#79 Multi-object launches with several options. Solenoid test case.#84lmdiazangulo wants to merge 10 commits into
lmdiazangulo wants to merge 10 commits into
Conversation
lmdiazangulo
changed the title
adrianarce-elemwave
requested changes
Aug 18, 2026
adrianarce-elemwave
left a comment
adrianarce-elemwave
left a comment
Collaborator
There was a problem hiding this comment.
I suggest to increase test coverage over new retriangulatePlanarPatches method
| EXPECT_EQ(1, countMeshElementsIf(r, isTriangle)); | ||
| } | ||
|
|
||
| TEST_F(SmootherTest, retriangulatesMirroredPlanarPatchesWithMirroredDiagonals) |
Collaborator
There was a problem hiding this comment.
The current test correctly covers the main nominal case, but additional tests should be added for non-triangular inputs, concave patches, degenerate patches, patches with multiple boundary cycles, and geometries crossing cell boundaries.
…for retriangulation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #79