Fix meeting_id not filled in ballot#504
Closed
bastianjoel wants to merge 3 commits into
Closed
Conversation
ostcar
reviewed
Apr 27, 2026
ostcar
approved these changes
Apr 27, 2026
Member
Author
|
When finalizing a secret approval poll I get following error: |
Member
|
I don't get the constrain. I don't see, that the vote logic needs this field. Why does the DB? |
Member
Author
|
ballot.yaml: Because of the |
Member
|
Could we remove that? I don't see, why we need this constrain? See also OpenSlides/openslides-meta#498 |
ostcar
requested changes
May 4, 2026
ostcar
left a comment
Member
There was a problem hiding this comment.
Please explain to me first, why the meeting_ids field in the ballot collection is necessary
Member
Author
|
Yes, removing that constraint would work too. |
Member
Author
|
Not needed anymore OpenSlides/openslides-meta#500 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meeting id now needs to be added to ballot because of the newly added equalfields constraints.
Go downgraded to align with other services.