Skip to content

Default Theme on setting #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nyan11 merged 5 commits into from
Dec 3, 2025
Merged

Default Theme on setting #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
08c4141
Starting the isuee
YannLeGoff Dec 3, 2025
8a51e82
Add default theme when openning the editor
YannLeGoff Dec 3, 2025
8d03067
Reemove useleess method
YannLeGoff Dec 3, 2025
8340eec
Fix not passing test
YannLeGoff Dec 3, 2025
71314e6
Merge 8d03067f9062f188fad5666a6c29ca1758c0a112
YannLeGoff Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions src/Pyramid-Toplo/PyramidThemeFromSpaceExtension.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,41 +11,43 @@ Class {
#category : #'Pyramid-Toplo-plugin-theme-management'
}

{ #category : #asserting }
PyramidThemeFromSpaceExtension class >> shouldInstall [

^ false
]

{ #category : #actions }
PyramidThemeFromSpaceExtension >> configureBuilder: aPyramidEditorBuilder [

(aPyramidEditorBuilder findPlugin: PyramidOpenFromSpacePlugin)
addExtension: self.
(aPyramidEditorBuilder findPlugin: PyramidSpacePlugin) builder
addExtension: self.
self themeSpaceSelector: (aPyramidEditorBuilder findPlugin: PyramidToploThemePlugin)
themePresenter themeSpaceSelector
| pyramidOpenFromSpacePlugin pyramidSpacePlugin pyramidToploThemePlugin |
[
pyramidOpenFromSpacePlugin := aPyramidEditorBuilder findPlugin:
PyramidOpenFromSpacePlugin.
pyramidSpacePlugin := aPyramidEditorBuilder findPlugin:
PyramidSpacePlugin.
pyramidToploThemePlugin := aPyramidEditorBuilder findPlugin:
PyramidToploThemePlugin ]
on: PyramidNoPluginFoundError
do: [ ^ self ].

pyramidOpenFromSpacePlugin addExtension: self.
pyramidSpacePlugin builder addExtension: self.
self themeSpaceSelector:
pyramidToploThemePlugin themePresenter themeSpaceSelector
]

{ #category : #'as yet unclassified' }
PyramidThemeFromSpaceExtension >> configureCloseOnSpace: aSpace [

aSpace toTheme: themeSpaceSelector currentTheme.
aSpace root skinManager postponeRequestSkinIn: aSpace root
]

{ #category : #'as yet unclassified' }
PyramidThemeFromSpaceExtension >> configureOpenFromSpace: aSpace [
"Do something with the space"

self defaultToTheme: aSpace toTheme.
aSpace root skinManager postponeRequestSkinIn: aSpace root
]

{ #category : #accessing }
PyramidThemeFromSpaceExtension >> defaultToTheme [

defaultToTheme ifNil: [ defaultToTheme := PyramidToploThemePlugin defaultTheme new ].
^ defaultToTheme
]

Expand Down
13 changes: 5 additions & 8 deletions src/Pyramid-Toplo/PyramidThemeSelectorPresenter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ PyramidThemeSelectorPresenter >> buttonRefreshTheme [
{ #category : #'as yet unclassified' }
PyramidThemeSelectorPresenter >> currentTheme [

^ self themeSelector selectedItem
^ self themeSelector selectedItem new
]

{ #category : #layout }
Expand Down Expand Up @@ -58,16 +58,14 @@ PyramidThemeSelectorPresenter >> initializeAllPossibleThemes [

allThemes := ToTheme allSubclasses select: [ :theme |
theme canBeDefault ].

allThemes := allThemes collect: [ :each | each new ].

self triggerThemeChangement: false.
self themeSelector items: allThemes.

(previousTheme isNotNil and: [ allThemes includes: previousTheme ])
ifTrue: [ self themeSelector selectItem: previousTheme ]
ifFalse: [ self themeSelector selectItem: allThemes first ].
self triggerThemeChangement: true.
ifFalse: [ self themeSelector selectItem: PyramidToploThemePlugin defaultTheme ].
self triggerThemeChangement: true
]

{ #category : #initialization }
Expand Down Expand Up @@ -96,9 +94,8 @@ PyramidThemeSelectorPresenter >> labelPresenter [
PyramidThemeSelectorPresenter >> selectTheme: aToTheme [

self triggerThemeChangement: false.
self themeSelector items do: [:theme | (theme class) = (aToTheme class) ifTrue: [ self themeSelector selectItem: (theme) ]].
self triggerThemeChangement: true.

self themeSelector selectItem: aToTheme class.
self triggerThemeChangement: true
]

{ #category : #'as yet unclassified' }
Expand Down
31 changes: 31 additions & 0 deletions src/Pyramid-Toplo/PyramidToploThemePlugin.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,40 @@ Class {
'themePresenter',
'themePropertyManager'
],
#classInstVars : [
'defaultTheme'
],
#category : #'Pyramid-Toplo-plugin-theme-management'
}

{ #category : #'as yet unclassified' }
PyramidToploThemePlugin class >> defaultTheme [

defaultTheme ifNil: [
defaultTheme := (ToTheme withAllSubclasses select: [ :e | e canBeDefault ]) last ].
^ defaultTheme
]

{ #category : #'as yet unclassified' }
PyramidToploThemePlugin class >> defaultTheme: anObject [

defaultTheme := anObject
]

{ #category : #'as yet unclassified' }
PyramidToploThemePlugin class >> defaultThemeSettingOn: aBuilder [

<systemsettings>
(aBuilder pickOne: #defaultTheme)
parent: #pyramid;
label: 'Choose the default theme.';
target: self;
domainValues:
(ToTheme withAllSubclasses select: #canBeDefault);
description:
'Define the theme that will be used by default when a new editor is opened.'
]

{ #category : #adding }
PyramidToploThemePlugin class >> toploAntIconCategory [

Expand Down