Update shell installer: fix URLs, improve Node/Bun setup, add password management#33
Merged
Merged
Conversation
install_node relied on 'source ~/.bashrc' to pick up Volta's PATH, but .bashrc returns early in non-interactive shells (piped 'wget ... | bash'), so npm/node were never on PATH for the rest of the script — breaking 'npm i -g nushell' and the global package installs. - Export VOLTA_HOME and PATH directly for the current session - Verify node/npm after install and report success/failure - Export BUN_INSTALL/PATH after the bun installer so bun is usable immediately, and register both volta and bun paths with fish only when fish is installed Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fy6VhHazSUDjgDefKf3WSH
- Check at script start whether root and user passwords are set (passwd -S); if missing, offer to use one password for both, prompt once, set via chpasswd, and cache sudo credentials so the password is reused throughout the run - Restore enable_ssh_with_password (was commented out but still referenced by the ssh component) and make it reuse the passwords collected at startup instead of prompting again - Fix the fish setup function: bash-style "$( wget ... )" made fish fail with 'command substitutions not allowed here'; pipe to bash instead and point at this repo's raw URL - Update stale usage URLs in the header to this repository Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fy6VhHazSUDjgDefKf3WSH
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the shell installer script with repository name corrections, improved installation reliability for Node.js and Bun, and adds password management functionality for SSH setup.
Key Changes
appdemo-starter-templatetostarter-app-dev-toolsand updated outdatedvtempest/server-shell-setupreferencewget -qO- ... | bash) instead of command substitution for better compatibilityVOLTA_HOMEand updatingPATHinstead of sourcing.bashrc(which fails in non-interactive shells)check_passwords()function to verify and set root/user passwords before installationenable_ssh_with_password()functioncheck_passwords()to avoid duplicate promptsNotable Implementation Details
passwd -Sto check if passwords are already set, avoiding unnecessary promptscheck_passwords()function is called early inmain()to ensure credentials are available for all subsequent operationshttps://claude.ai/code/session_01Fy6VhHazSUDjgDefKf3WSH