Skip to content

Add module gallery - #321

Merged
Quentinchampenois merged 4 commits into
developfrom
feature/add-gallery
Jun 21, 2023
Merged

Quentinchampenois merged 4 commits into
developfrom
feature/add-gallery

Conversation

@armandfardeau

Copy link
Copy Markdown
Collaborator

🎩 Description

Add module gallery

📌 Related Issues

Tasks

  • In case of new dependencies or version bump, update related documentation

@armandfardeau
armandfardeau requested review from a team, Ouardaoubahri and Quentinchampenois and removed request for a team June 12, 2023 15:26
@armandfardeau
armandfardeau marked this pull request as ready for review June 12, 2023 15:34
@codecov

codecov Bot commented Jun 12, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage has no change and project coverage change: -0.34 ⚠️

Comparison is base (39fffd4) 73.51% compared to head (2d4dc87) 73.18%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #321      +/-   ##
===========================================
- Coverage    73.51%   73.18%   -0.34%     
===========================================
  Files           64       63       -1     
  Lines         1752     1667      -85     
===========================================
- Hits          1288     1220      -68     
+ Misses         464      447      -17     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@armandfardeau
armandfardeau marked this pull request as draft June 12, 2023 15:41
@armandfardeau

armandfardeau commented Jun 13, 2023

Copy link
Copy Markdown
Collaborator Author

Wait for mainio/decidim-module-term_customizer#103 to be merged and backported
Depends on decidim/decidim#10993

@paulinebessoles
paulinebessoles marked this pull request as ready for review June 21, 2023 09:41
@paulinebessoles
paulinebessoles requested review from a team, Quentinchampenois, moustachu and paulinebessoles and removed request for a team June 21, 2023 10:18
@paulinebessoles
paulinebessoles removed the request for review from moustachu June 21, 2023 14:00

@Quentinchampenois Quentinchampenois left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must update the decidim-term_customizer source once fixed

@Quentinchampenois
Quentinchampenois merged commit fcbf592 into develop Jun 21, 2023
@Quentinchampenois
Quentinchampenois deleted the feature/add-gallery branch June 21, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants