iroute: release old peer context when adding iroute

PropertySheet.props

@@ -4,7 +4,7 @@
   <PropertyGroup Label="UserMacros">
     <OVPN_DCO_VERSION_MAJOR>2</OVPN_DCO_VERSION_MAJOR>
     <OVPN_DCO_VERSION_MINOR>7</OVPN_DCO_VERSION_MINOR>
-    <OVPN_DCO_VERSION_PATCH>0</OVPN_DCO_VERSION_PATCH>
+    <OVPN_DCO_VERSION_PATCH>1</OVPN_DCO_VERSION_PATCH>
   </PropertyGroup>
   <PropertyGroup />
   <ItemDefinitionGroup>

trie.cpp

@@ -138,6 +138,8 @@ IPTrie::Insert(const UCHAR* ip, int prefixLength, OvpnPeerContext* peer) {
     }
 
     // update the node with the peer info
+    // keep track of any existing peer so we can release it outside the lock
+    OvpnPeerContext* oldPeer = current->peer;
     current->peer = peer;
     current->isRoute = true;
 
@@ -148,6 +150,12 @@ IPTrie::Insert(const UCHAR* ip, int prefixLength, OvpnPeerContext* peer) {
 
     ExReleaseSpinLockExclusive(&Lock, kirql);
 
+    // release the previous peer outside the lock if it existed
+    if (oldPeer) {
+        LOG_INFO("Release previous peer", TraceLoggingValue(oldPeer->PeerId, "peerId"));
+        OvpnPeerCtxRelease(oldPeer);
+    }
+
 done:
     LOG_EXIT();
     return status;