Skip to content

fix(logging): rename isEventEnabled to shouldLogEvent #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Alexteens24 wants to merge 1 commit into from
Closed

fix(logging): rename isEventEnabled to shouldLogEvent #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/java/github/nighter/smartspawner/logging/LoggingConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public Set<SpawnerEventType> getEnabledEvents() {
return new HashSet<>(enabledEvents);
}

public boolean isEventEnabled(SpawnerEventType eventType) {
return !enabled || !enabledEvents.contains(eventType);
public boolean shouldLogEvent(SpawnerEventType eventType) {
return enabled && enabledEvents.contains(eventType);
}
}
4 changes: 2 additions & 2 deletions core/src/main/java/github/nighter/smartspawner/logging/SpawnerActionLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public SpawnerActionLogger(SmartSpawner plugin, LoggingConfig config) {
* Logs a spawner action asynchronously.
*/
public void log(SpawnerLogEntry entry) {
if (!config.isEnabled() || config.isEventEnabled(entry.getEventType())) {
if (!config.isEnabled() || !config.shouldLogEvent(entry.getEventType())) {
return;
}

Expand All @@ -79,7 +79,7 @@ public void log(SpawnerLogEntry entry) {
* Logs a spawner action using a builder pattern.
*/
public void log(SpawnerEventType eventType, LogEntryConsumer consumer) {
if (!config.isEnabled() || config.isEventEnabled(eventType)) {
if (!config.isEnabled() || !config.shouldLogEvent(eventType)) {
return;
}

Expand Down