Refactor politics and leftovers to use reference_wrapper#711
Open
Refactor politics and leftovers to use reference_wrapper#711
Conversation
Spartan322
reviewed
Feb 25, 2026
Spartan322
reviewed
Feb 25, 2026
Spartan322
reviewed
Feb 25, 2026
Spartan322
reviewed
Feb 25, 2026
wvpm
force-pushed
the
refactor_politics_reference_wrapper
branch
from
d747489 to
6bc573c
Compare
wvpm
changed the title
wvpm
force-pushed
the
refactor_politics_reference_wrapper
branch
from
6bc573c to
7a01d15
Compare
Spartan322
reviewed
Feb 25, 2026
wvpm
force-pushed
the
refactor_politics_reference_wrapper
branch
from
7a01d15 to
4eb45b5
Compare
wvpm
force-pushed
the
refactor_politics_reference_wrapper
branch
from
d0d75d9 to
1173460
Compare
Spartan322
reviewed
Feb 26, 2026
|
|
||
| #include <concepts/type_traits.hpp> | ||
|
|
||
| //bug fix for std::hash & std::equal_to to work with std::reference_wrapper |
Member
There was a problem hiding this comment.
Suggested change
| //bug fix for std::hash & std::equal_to to work with std::reference_wrapper | |
| // bug fix for std::hash & std::equal_to to work with std::reference_wrapper |
Spartan322
reviewed
Feb 26, 2026
| }; | ||
| } | ||
|
|
||
| //bug fix for concepts/type_traits.hpp to work with std::reference_wrapper |
Member
There was a problem hiding this comment.
Suggested change
| //bug fix for concepts/type_traits.hpp to work with std::reference_wrapper | |
| // bug fix for concepts/type_traits.hpp to work with std::reference_wrapper |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #707 , #708, #709 & #710
This should be most of what those PRs didn't touch.
BaseIssueGroup is replaced with an std::variant. This avoid recasting and improves type safety.