Skip to content
This repository was archived by the owner on May 31, 2021. It is now read-only.

Spotim ad#1

Open
liorpr wants to merge 6 commits into
masterfrom
spotim-ad
Open

Spotim ad#1
liorpr wants to merge 6 commits into
masterfrom
spotim-ad

Conversation

@liorpr
Copy link
Copy Markdown

@liorpr liorpr commented Jan 14, 2019

No description provided.

Copy link
Copy Markdown

@dortzur dortzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work.
One comment below

Comment thread ads/spotim.js Outdated
*/
export function spotim(global, data) {
validateData(data, ['spotId']);
loadScript(global, 'http://localhost:6050/amp-ad-launcher/');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localhost in code instead of production

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants