fix: disable Hold mode on Linux when /dev/input permissions are missing#680
Open
xAlcahest wants to merge 1 commit intoOpenWhispr:mainfrom
Open
fix: disable Hold mode on Linux when /dev/input permissions are missing#680xAlcahest wants to merge 1 commit intoOpenWhispr:mainfrom
xAlcahest wants to merge 1 commit intoOpenWhispr:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Linux, Hold mode (push-to-talk) requires read access to /dev/input/event* devices via the
inputgroup. Previously, Hold mode was always selectable even when the user lacked permissions, resulting in a broken hotkey with no feedback. Now the app proactively checks /dev/input permissions at startup and disables the Hold button when access is missing, showing setup instructions inline instead of waiting for the error to happen.Changes
Fixes #611