Skip to content

fix(Makefile): track CUTE scala sources in Makefile#63

Merged
yu-yake2002 merged 1 commit into
masterfrom
fix/track_CUTEsrc
May 9, 2026
Merged

fix(Makefile): track CUTE scala sources in Makefile#63
yu-yake2002 merged 1 commit into
masterfrom
fix/track_CUTEsrc

Conversation

@ecall73
Copy link
Copy Markdown

@ecall73 ecall73 commented May 8, 2026

Summary

  • Make now tracks Scala sources in both src/main/scala and CUTE/src/main/scala.
  • This ensures CUTE-internal Scala edits trigger rebuild of related RTL outputs.
  • Added optional-directory handling to avoid parse-time find noise when CUTE is absent.

Workstream And Scope

  • Primary workstream: XSAI RTL flow / build orchestration
  • Main paths touched:
    • Makefile
  • Coupled areas or upstream links:
    • None; dependency-list update only

Review Focus

  • Confirm dependency tracking now covers CUTE/src/main/scala.
  • Confirm no side effects for environments where CUTE is not initialized.

@ecall73 ecall73 requested review from Wonicon and yu-yake2002 May 8, 2026 02:49
@ecall73 ecall73 self-assigned this May 8, 2026
Copilot AI review requested due to automatic review settings May 8, 2026 02:49
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the build dependency tracking in the top-level Makefile so that changes to Scala sources under the optional CUTE/src/main/scala tree will correctly trigger regeneration of RTL outputs, while avoiding find errors when CUTE is not present.

Changes:

  • Add a SCALA_DIRS list that includes ./src/main/scala plus ./CUTE/src/main/scala when it exists.
  • Update SCALA_FILE discovery to run find over SCALA_DIRS, ensuring CUTE-internal Scala edits participate in rebuild triggering.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yu-yake2002 yu-yake2002 merged commit 67d7851 into master May 9, 2026
19 of 22 checks passed
@yu-yake2002
Copy link
Copy Markdown
Collaborator

After we merged multiple new precisions into the master, the compilation speed decreased significantly. Next, it is necessary to optimize the compilation speed. @Wonicon

@yu-yake2002 yu-yake2002 deleted the fix/track_CUTEsrc branch May 9, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants