Skip to content

chore: avoid double parsing tx_summary in offline execution#123

Open
VolodymyrBg wants to merge 1 commit intoOpenZeppelin:mainfrom
VolodymyrBg:fix/offline-execute-imported-proposal-tx-summary
Open

chore: avoid double parsing tx_summary in offline execution#123
VolodymyrBg wants to merge 1 commit intoOpenZeppelin:mainfrom
VolodymyrBg:fix/offline-execute-imported-proposal-tx-summary

Conversation

@VolodymyrBg
Copy link
Copy Markdown

execute_imported_proposal was re-parsing tx_summary from JSON even though ExportedProposal::to_proposal had already deserialized it. This led to unnecessary work and allocations and was inconsistent with the online execution flow, which relies on proposal.tx_summary directly. Micro-optimization and a bit of clean-up

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@VolodymyrBg
Copy link
Copy Markdown
Author

I confirm that I have read and hereby agree to the OpenZeppelin Contributor License Agreement

@VolodymyrBg
Copy link
Copy Markdown
Author

I confirm that I have read and hereby agree to the OpenZeppelin Contributor License Agreement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant