Skip to content

Expose MAX_WEBHOOK_PAYLOAD_SIZE option#75

Merged
wesleyjellis merged 1 commit intomainfrom
max-webook-payload-size
Sep 12, 2025
Merged

Expose MAX_WEBHOOK_PAYLOAD_SIZE option#75
wesleyjellis merged 1 commit intomainfrom
max-webook-payload-size

Conversation

@wesleyjellis
Copy link
Copy Markdown
Contributor

Resolves #

Problem

We're changing the default for max webhook size from 4MB to unlimited as the default for self-hosted releases. Expose a variable to allow setting it in the helm chart

Solution

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • Make a changie entry that explains the customer facing outcome of this change

@@ -0,0 +1,3 @@
kind: Feature
body: Add `opslevel.web.maxWebhookPayloadSize` to set `MAX_WEBHOOK_PAYLOAD_SIZE` for Rails web.
Copy link
Copy Markdown
Collaborator

@rocktavious rocktavious Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may seem self explanatory to you with all your context but put yourself into the customer shoes for a second and think from their perspective when they read this change entry with no context - they have no idea why you would want to tweak MAX_WEBHOOK_PAYLOAD_SIZE so lets expand this change entry to tell our self hosted customers why exactly they'd want to set this. (Basically and expaned version of what you added in the comment below in values.yaml but make sure its in the change log so the customers who just read the changelog know why they should care about this change)

Copy link
Copy Markdown
Contributor Author

@wesleyjellis wesleyjellis Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like:

Add opslevel.web.maxWebhookPayloadSize. Webhook payloads (like custom event checks) larger than this will be rejected with a 413. Default is 0/unlimited.`

Copy link
Copy Markdown
Collaborator

@rocktavious rocktavious Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya thats definitely more context - maybe be more specific because its not clear if its inbound or outbound - like Payloads sent to the OpsLevel web app (like custom event checks and sboms)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@wesleyjellis wesleyjellis force-pushed the max-webook-payload-size branch from 88d51f8 to 33ffe2e Compare September 11, 2025 17:32
@wesleyjellis wesleyjellis merged commit 91b296d into main Sep 12, 2025
1 check passed
@wesleyjellis wesleyjellis deleted the max-webook-payload-size branch September 12, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants