Expose MAX_WEBHOOK_PAYLOAD_SIZE option#75
Conversation
| @@ -0,0 +1,3 @@ | |||
| kind: Feature | |||
| body: Add `opslevel.web.maxWebhookPayloadSize` to set `MAX_WEBHOOK_PAYLOAD_SIZE` for Rails web. | |||
There was a problem hiding this comment.
This may seem self explanatory to you with all your context but put yourself into the customer shoes for a second and think from their perspective when they read this change entry with no context - they have no idea why you would want to tweak MAX_WEBHOOK_PAYLOAD_SIZE so lets expand this change entry to tell our self hosted customers why exactly they'd want to set this. (Basically and expaned version of what you added in the comment below in values.yaml but make sure its in the change log so the customers who just read the changelog know why they should care about this change)
There was a problem hiding this comment.
Something like:
Add
opslevel.web.maxWebhookPayloadSize. Webhook payloads (like custom event checks) larger than this will be rejected with a 413. Default is 0/unlimited.`
There was a problem hiding this comment.
ya thats definitely more context - maybe be more specific because its not clear if its inbound or outbound - like Payloads sent to the OpsLevel web app (like custom event checks and sboms)
88d51f8 to
33ffe2e
Compare
Resolves #
Problem
We're changing the default for max webhook size from 4MB to unlimited as the default for self-hosted releases. Expose a variable to allow setting it in the helm chart
Solution
Checklist