Skip to content

Add componentChecks tool, listing checks in rubric#52

Merged
wesleyjellis merged 3 commits intomainfrom
wesley/componentChecks
Jun 10, 2025
Merged

Add componentChecks tool, listing checks in rubric#52
wesleyjellis merged 3 commits intomainfrom
wesley/componentChecks

Conversation

@wesleyjellis
Copy link
Copy Markdown
Contributor

componentChecks lists the rubric of checks for a given component

Problem

There's no way to view the rubric/check results for a given component

Solution

List the checks and results arranged in the rubric

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Make a changie entry that explains the customer facing outcome of this change.

componentChecks lists the rubric of checks for a given component
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the "componentChecks" tool, which lists rubric-based check results for a given OpsLevel component.

  • Adds a new tool "componentChecks" in the CLI command with processing logic to format and return check results.
  • Updates dependency management in go.mod for the iso8601 package and syncs the submodule pointer for opslevel-go.
  • Adds a changelog entry for the new componentChecks tool.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/submodules/opslevel-go Updated subproject commit pointer
src/go.mod Added direct dependency for github.com/relvacode/iso8601 and removed its indirect listing
src/cmd/root.go Introduced new types and added the componentChecks tool to the CLI
.changes/unreleased/Added-20250609-161700.yaml Changelog entry detailing the addition of the componentChecks tool

Comment thread src/cmd/root.go
Comment thread src/cmd/root.go
Copy link
Copy Markdown
Contributor

@rocktavious rocktavious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 suggestions and 1 question

@wesleyjellis
Copy link
Copy Markdown
Contributor Author

@rocktavious any idea why the tests are failing to check out the right commit for the submodule? You can see here it grabs the correct SHA but a few lines later it's gone back 1 commit

@rocktavious
Copy link
Copy Markdown
Contributor

@wesleyjellis its not using the submodule because this line is commented out. https://github.com/OpsLevel/opslevel-mcp/blob/main/src/go.mod#L58

@wesleyjellis
Copy link
Copy Markdown
Contributor Author

@rocktavious do we need to cut a release for opslevel-go or should I pin a specific commit with the submodule and uncomment that line?

@rocktavious
Copy link
Copy Markdown
Contributor

For WIP releases we usually uncomment and commit updates to the submodule. Then part of the release process is to do 1 last commit that updates opslevel-go (when its released) and comment out (something we should probably automate).

@wesleyjellis wesleyjellis force-pushed the wesley/componentChecks branch from 260da13 to dff2696 Compare June 10, 2025 12:33
@wesleyjellis wesleyjellis merged commit 7628a23 into main Jun 10, 2025
2 checks passed
@wesleyjellis wesleyjellis deleted the wesley/componentChecks branch June 10, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants