Upgrade mcp-go to v0.31.0#54
Merged
wesleyjellis merged 1 commit intomainfrom Jun 10, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the mcp-go dependency to v0.31.0, updates tool annotations to use pointer booleans, and refactors how command arguments are fetched.
- Bump
github.com/mark3labs/mcp-gofrom v0.23.1 to v0.31.0 - Add
boolPtrhelper and change allToolAnnotationhints fromboolto*bool - Replace manual
req.Params.Argumentscasts withreq.RequireString/req.GetStringmethods
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/go.mod | Updated mcp-go dependency version |
| src/cmd/root.go | Added boolPtr, switched annotation hints to *bool, refactored argument fetching |
Comments suppressed due to low confidence (1)
src/cmd/root.go:323
- The new
RequireStringerror paths introduce failure branches that aren’t covered by existing tests. Add unit tests to verify behavior when required arguments are missing or invalid.
resourceTypeString, err := req.RequireString("resourceType")
rocktavious
approved these changes
Jun 10, 2025
Contributor
rocktavious
left a comment
There was a problem hiding this comment.
Overall i'm 👍 but Copilot does have a slightly good suggestion
- Change tool annotation type from bool to *bool - Change the way we fetch arguments to new method
fa0773f to
58636d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist