Skip to content

Upgrade mcp-go to v0.31.0#54

Merged
wesleyjellis merged 1 commit intomainfrom
wesley/upgrade-mcp-go
Jun 10, 2025
Merged

Upgrade mcp-go to v0.31.0#54
wesleyjellis merged 1 commit intomainfrom
wesley/upgrade-mcp-go

Conversation

@wesleyjellis
Copy link
Copy Markdown
Contributor

  • Change tool annotation type from bool to *bool
  • Change the way we fetch arguments to new method

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Make a changie entry that explains the customer facing outcome of this change.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the mcp-go dependency to v0.31.0, updates tool annotations to use pointer booleans, and refactors how command arguments are fetched.

  • Bump github.com/mark3labs/mcp-go from v0.23.1 to v0.31.0
  • Add boolPtr helper and change all ToolAnnotation hints from bool to *bool
  • Replace manual req.Params.Arguments casts with req.RequireString/req.GetString methods

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/go.mod Updated mcp-go dependency version
src/cmd/root.go Added boolPtr, switched annotation hints to *bool, refactored argument fetching
Comments suppressed due to low confidence (1)

src/cmd/root.go:323

  • The new RequireString error paths introduce failure branches that aren’t covered by existing tests. Add unit tests to verify behavior when required arguments are missing or invalid.
resourceTypeString, err := req.RequireString("resourceType")

Comment thread src/cmd/root.go
Copy link
Copy Markdown
Contributor

@rocktavious rocktavious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall i'm 👍 but Copilot does have a slightly good suggestion

 - Change tool annotation type from bool to *bool
 - Change the way we fetch arguments to new method
@wesleyjellis wesleyjellis force-pushed the wesley/upgrade-mcp-go branch from fa0773f to 58636d5 Compare June 10, 2025 19:21
@wesleyjellis wesleyjellis merged commit c36d550 into main Jun 10, 2025
2 checks passed
@wesleyjellis wesleyjellis deleted the wesley/upgrade-mcp-go branch June 10, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants