Fix component type update deleting unmanaged relationships#646
Merged
saditya370 merged 3 commits intoOpsLevel:mainfrom Apr 21, 2026
Merged
Conversation
andrewstillv15
approved these changes
Apr 20, 2026
Contributor
|
We have to add a changie before this gets merged |
andrewstillv15
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
relationshipsblock. Reported by LandSure on provider v1.9.0 (GitLab #14723).reconcileRelationships()ran unconditionally on every update and deleted any API-side relationship not found in the current plan. A nil/empty plan meant "delete everything."Test plan
TestReconcileRelationships_NilPlanNilState— no relationships in plan or state → no deletesTestReconcileRelationships_NilPlanWithState— user removes relationships block → deletes only what was in stateTestReconcileRelationships_PlanMatchesAPI— no changes → updates only, no deletesTestReconcileRelationships_EmptyPlanNilState— empty map with nil state → no deletesTestReconcileRelationships_APIHasExtraNotInState— UI-created relationships → left untouchedTestReconcileRelationships_RemoveOneKeepOne— partial removal → deletes one, updates otherTestReconcileRelationships_AddNewRelationship— new relationship added → creates it, no deletesTestReconcileRelationships_RemoveAllFromState— explicit removal of all → deletes all from stateTestReconcileRelationships_StateHasOneAPIHasExtraKeepBoth— TF manages one, UI created another → only updates TF-managed onego test ./opslevel/— 12/12)go build ./...)