perf(prebid-analytics): drop the discarded auction transform in trackAuctionEnd - #334
Open
mosherBT wants to merge 1 commit into
Open
perf(prebid-analytics): drop the discarded auction transform in trackAuctionEnd#334mosherBT wants to merge 1 commit into
mosherBT wants to merge 1 commit into
Conversation
…AuctionEnd trackAuctionEnd built a full auction model - mapped bidderRequests with deduplicated EIDs, mapped bids, three lookup indexes, then merged in bidsReceived, noBids and timeoutBids - and never read the result. The stored auction keeps the raw event, and toWitness recomputes the same transformation from that raw event when the bidWinTimeout fires. Deleting it halves the per-auction work with no change to the payload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
trackAuctionEndbuilt a full auction model — mapped bidder requests with EID dedup, mapped bids, three lookup indexes, then merged inbidsReceived/noBids/timeoutBids— and never read the result, because the stored auction keeps the raweventandtoWitnessrecomputes the identical transformation when thebidWinTimeoutfires.What Changed
lib/addons/prebid/analytics.ts: delete the discarded transform (~131 lines), roughly halving per-auction work on the auction-end path with no change to the witness payload.timeout,bidsReceivedandnoBidsfrom the destructuring, since only the deleted block used them.How to Test
Notes