Skip to content

Fix template injection in release/build workflows #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ratelle wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −7
Open

Fix template injection in release/build workflows #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,15 @@ jobs:
# - v.12.2.1 and patching v.12.2.2, we update v12
- name: Determine versions to update
id: sdk-versions
run: ./scripts/versions-to-update.sh @optable/web-sdk ${{ github.ref_name }} >> "$GITHUB_OUTPUT"
env:
REF_NAME: ${{ github.ref_name }}
run: ./scripts/versions-to-update.sh @optable/web-sdk "$REF_NAME" >> "$GITHUB_OUTPUT"

- name: Show versions that will be updated
env:
SDK_VERSIONS: ${{ steps.sdk-versions.outputs.versions }}
run: |
echo "SDK versions: ${{ steps.sdk-versions.outputs.versions }}"
echo "SDK versions: $SDK_VERSIONS"

deploy-sdk-to-npm:
needs: [build, define-gcs-versions-to-update]
Expand All @@ -78,7 +82,9 @@ jobs:

# Step will fail if the version is invalid, github.ref_name is the tag name (v.*.*.*)
- name: Patch version
run: ./scripts/patch-version.sh "${{ github.ref_name }}"
env:
REF_NAME: ${{ github.ref_name }}
run: ./scripts/patch-version.sh "$REF_NAME"

- name: Setup pnpm
uses: ./.github/actions/setup-pnpm
Expand Down Expand Up @@ -165,9 +171,11 @@ jobs:
service_account: ${{ env.service-account }}

- name: Build web-sdk-demos Docker Image
env:
REF_NAME: ${{ github.ref_name }}
run: |
DOCKER_BUILDKIT=1 docker build \
-t us-docker.pkg.dev/optable-artifact-registry/optable/optable-web-sdk-demos:${{ github.ref_name }} \
-t "us-docker.pkg.dev/optable-artifact-registry/optable/optable-web-sdk-demos:$REF_NAME" \
./demos

- name: Login to Google Artifact Registry
Expand All @@ -178,7 +186,9 @@ jobs:
password: ${{ steps.auth.outputs.access_token }}

- name: Publish web-sdk-demos to us-docker.pkg.dev
run: docker push us-docker.pkg.dev/optable-artifact-registry/optable/optable-web-sdk-demos:${{ github.ref_name }}
env:
REF_NAME: ${{ github.ref_name }}
run: docker push "us-docker.pkg.dev/optable-artifact-registry/optable/optable-web-sdk-demos:$REF_NAME"

slack-notification:
needs: [tests-prettier, build, deploy-sdk-to-npm, define-gcs-versions-to-update, deploy-sdk-to-gcs, deploy-demo]
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/reusable-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ jobs:
uses: ./.github/actions/setup-pnpm

- name: Patch build.json version
run: ./scripts/patch-version.sh "${{ inputs.version }}"
env:
VERSION: ${{ inputs.version }}
run: ./scripts/patch-version.sh "$VERSION"

- name: Build web production
run: pnpm build-web --mode=production
Expand All @@ -45,7 +47,9 @@ jobs:
uses: ./.github/actions/setup-pnpm

- name: Patch build.json version
run: ./scripts/patch-version.sh "${{ inputs.version }}"
env:
VERSION: ${{ inputs.version }}
run: ./scripts/patch-version.sh "$VERSION"

- name: Transpile lib
run: pnpm build-lib
Expand Down