fix: restore missing JSDoc comment in stellar.ts - #112
Open
Ash739-ux wants to merge 1 commit into
Open
Conversation
|
Please unlink issue 67 as it was assigned to me and your pr makes it difficult for me to solve the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66
📝 Description
Title:
fix: restore missing JSDoc comment boundary in StellarService to resolve build failures📝 Description
Context & Root Cause
This PR addresses a critical build failure stemming from a syntax error in
src/services/stellar.ts. The opening boundary (/**) of a JSDoc comment for thesubmitWithAdditionalSignaturesmethod was accidentally deleted.Because the opening boundary was missing, TypeScript's parser interpreted the first asterisk (
* Merges additional...) as a multiplication operator and subsequent text as an unterminated regular expression literal. This triggered a severe cascading parse failure, generating over 60 spurious downstream syntax errors (e.g.,error TS1005: '(' expectedanderror TS1434: Unexpected keyword or identifier) in this single file.Impact
src/services/stellar.tsfailed to compile.StellarService(which is most of the application).tests/services/stellar.multisig.test.ts) from running.Changes Made
/**and the full JSDoc comment body immediately preceding thesubmitWithAdditionalSignaturesmethod declaration.🔗 Related Issues
ifblock for MemoRequiredError breaks the TypeScript build #64, wallet.ts: POST /wallet/fee-bump has no request handler — its body was merged into /path-payment-strict-send #65, stellar.ts: duplicate import of SequenceConflictError from stellarErrors #67 (Part of the coordinated effort to eliminate independent compile blockers).🧪 Testing & Verification Strategy
The fix can be quickly and cleanly verified via the TypeScript compiler without needing to spin up the full test suite.
Steps to verify:
npx tsc --noEmit(ornpm run type-check).src/services/stellar.ts, confirming the syntax tree is fully restored.npx jest tests/services/stellar.multisig.test.ts.✅ Checklist
tsc --noEmitpasses).