Skip to content

fix: restore missing JSDoc comment in stellar.ts - #112

Open
Ash739-ux wants to merge 1 commit into
Orbit-Wal:mainfrom
Ash739-ux:fix-stellar-jsdoc-syntax-error
Open

fix: restore missing JSDoc comment in stellar.ts#112
Ash739-ux wants to merge 1 commit into
Orbit-Wal:mainfrom
Ash739-ux:fix-stellar-jsdoc-syntax-error

Conversation

@Ash739-ux

Copy link
Copy Markdown

Closes #66

📝 Description

Title: fix: restore missing JSDoc comment boundary in StellarService to resolve build failures

📝 Description

Context & Root Cause
This PR addresses a critical build failure stemming from a syntax error in src/services/stellar.ts. The opening boundary (/**) of a JSDoc comment for the submitWithAdditionalSignatures method was accidentally deleted.

Because the opening boundary was missing, TypeScript's parser interpreted the first asterisk (* Merges additional...) as a multiplication operator and subsequent text as an unterminated regular expression literal. This triggered a severe cascading parse failure, generating over 60 spurious downstream syntax errors (e.g., error TS1005: '(' expected and error TS1434: Unexpected keyword or identifier) in this single file.

Impact

  • src/services/stellar.ts failed to compile.
  • Blocked compilation for any route or test importing StellarService (which is most of the application).
  • Prevented the Jest test suite (specifically tests/services/stellar.multisig.test.ts) from running.

Changes Made

  • Restored the missing /** and the full JSDoc comment body immediately preceding the submitWithAdditionalSignatures method declaration.

🔗 Related Issues

🧪 Testing & Verification Strategy

The fix can be quickly and cleanly verified via the TypeScript compiler without needing to spin up the full test suite.

Steps to verify:

  1. Run a dry type-check: npx tsc --noEmit (or npm run type-check).
  2. Expected Result: Zero errors reported in src/services/stellar.ts, confirming the syntax tree is fully restored.
  3. Run the specific unit test: npx jest tests/services/stellar.multisig.test.ts.
  4. Expected Result: The test file successfully compiles and runs.

✅ Checklist

  • Code compiles successfully (tsc --noEmit passes).
  • Unrelated code and existing logic remains untouched.
  • PR addresses the root cause directly without masking the underlying issue.

@onyekachi66

Copy link
Copy Markdown

Please unlink issue 67 as it was assigned to me and your pr makes it difficult for me to solve the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stellar.ts: orphaned JSDoc block (missing /** opener) breaks compilation of the entire file

3 participants