fix(globe-wallet): clean up SpendLimit and DailySpent in remove_asset (fixes #89) - #100
Closed
s6pa1rta3n-lab wants to merge 1 commit into
Closed
fix(globe-wallet): clean up SpendLimit and DailySpent in remove_asset (fixes #89)#100s6pa1rta3n-lab wants to merge 1 commit into
s6pa1rta3n-lab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #89 by ensuring that
GlobeWallet::remove_assetcleans up the corresponding persistent storage entries forSpendLimit(user, asset_code)andDailySpent(user, asset_code)when an asset is removed from a user'sUserAssetslist, matching the existing cleanup behavior inmigrate_user_assets.Changes
GlobeWallet::remove_asset, explicitly callenv.storage().persistent().remove(&DataKey::SpendLimit(user.clone(), asset_code.clone()))andenv.storage().persistent().remove(&DataKey::DailySpent(user.clone(), asset_code.clone())).test_remove_asset_cleans_up_spend_limit_and_daily_spentproving thatget_spend_limitreturns to the default (0 / unlimited) and storage keys are completely removed after callingremove_asset.test_readding_previously_removed_asset_has_fresh_unconfigured_limitproving that re-adding a previously-removed asset starts with a fresh, unconfigured limit rather than inheriting the old one.migrate_user_assets's cleanup continues to work with no regression.Definition of Done Verification
remove_assetremoves the correspondingSpendLimitandDailySpententries for the removed assetget_spend_limitreturns to the default (0 / unlimited) afterremove_assetmigrate_user_assets's existing equivalent cleanupcargo test --workspacepasses cleanly (71 tests in globe-wallet, 1 integration test, 11 tests in token-wrapper)Payout Routing
0xF46C9F6d70C50BF81ef3588AB523a90a594a2F89GCL6OXAMLD75BMTINA6EMRUDWK5THQUSHMYNLSNBCJAPZJHNYJTUNIBC