fix: Consolidate MAX_ASSETS constants in GlobeWallet - #74
Open
samuelfrancis163-eng wants to merge 1 commit into
Open
fix: Consolidate MAX_ASSETS constants in GlobeWallet#74samuelfrancis163-eng wants to merge 1 commit into
samuelfrancis163-eng wants to merge 1 commit into
Conversation
Removed the duplicate module-level MAX_ASSETS constant in favor of GlobeWallet::MAX_ASSETS which is actually used by the enforcement logic. Also updated tests to consistently use GlobeWallet::MAX_ASSETS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31
Removed the duplicate module-level MAX_ASSETS constant in favor of GlobeWallet::MAX_ASSETS which is actually used by the enforcement logic. Also updated tests to consistently use GlobeWallet::MAX_ASSETS.
Issue
Closes #
Root cause
What changed and why
Definition of done — addressed item by item
Evidence this actually runs
Tests
Regression check
Checklist
console.log/TODO/debug code