fix: remove redundant use super::* import in tests - #76
Open
Ash739-ux wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35
Description
Context
In the
testsmodule ofcontracts/globe-wallet/src/lib.rs, there was a duplicate import block at the beginning of the module.Problem
The
use super::*;statement appeared twice consecutively. While Rust's glob-import semantics permit this without throwing a compiler error (because both statements independently re-export the same names into thetestsmodule's namespace), it is an obvious copy-paste artifact. It also triggersunused_importsor redundant-import lints (such as incargo clippy), creating unnecessary lint noise.This minor duplication fits a broader pattern of copy-paste/merge artifacts found elsewhere in this codebase (e.g., duplicate enum variants, duplicate constants).
Fix
Deleted one of the identical
use super::*;lines so only one remains at the top of thetestsmodule.Definition of Done
use super::*;remains at the top of thetestsmodule.cargo check --testswithout throwing redundant import warnings for this specific block.Related Issues
This issue shares the same "duplication survived a merge/copy-paste" root cause as the duplicate enum variants and the duplicate
MAX_ASSETSconstant in this file.