Skip to content

fix: remove redundant use super::* import in tests - #76

Open
Ash739-ux wants to merge 1 commit into
Orbit-Wal:mainfrom
Ash739-ux:fix-redundant-use-super
Open

fix: remove redundant use super::* import in tests#76
Ash739-ux wants to merge 1 commit into
Orbit-Wal:mainfrom
Ash739-ux:fix-redundant-use-super

Conversation

@Ash739-ux

Copy link
Copy Markdown

Closes #35

Description

Context

In the tests module of contracts/globe-wallet/src/lib.rs, there was a duplicate import block at the beginning of the module.

Problem

The use super::*; statement appeared twice consecutively. While Rust's glob-import semantics permit this without throwing a compiler error (because both statements independently re-export the same names into the tests module's namespace), it is an obvious copy-paste artifact. It also triggers unused_imports or redundant-import lints (such as in cargo clippy), creating unnecessary lint noise.

This minor duplication fits a broader pattern of copy-paste/merge artifacts found elsewhere in this codebase (e.g., duplicate enum variants, duplicate constants).

Fix

Deleted one of the identical use super::*; lines so only one remains at the top of the tests module.

Definition of Done

  • Only one use super::*; remains at the top of the tests module.
  • Code cleanly passes cargo check --tests without throwing redundant import warnings for this specific block.

Related Issues

This issue shares the same "duplication survived a merge/copy-paste" root cause as the duplicate enum variants and the duplicate MAX_ASSETS constant in this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate use super::*; import in the globe-wallet test module

2 participants