fix(cli): build Node UI bundle during blue-green update#354
Open
fix(cli): build Node UI bundle during blue-green update#354
Conversation
60c60f2 to
b077625
Compare
b077625 to
6a65ff1
Compare
6a65ff1 to
a4ed4c3
Compare
a4ed4c3 to
0ff5c44
Compare
0ff5c44 to
687882d
Compare
687882d to
fb750f9
Compare
fb750f9 to
a693a71
Compare
a693a71 to
51b12d5
Compare
51b12d5 to
c7b1cd8
Compare
c7b1cd8 to
293980a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist-ui/index.htmlartifact before update/rollback activation can swap: git-layout slots require freshly rebuiltpackages/node-ui/dist-ui/index.html, while npm-layout slots require the UI package candidate declared by installed CLI metadata when readable.dkg updatefrom mutating the currently served slot during migration preflight.Related
Fixes #347
Files changed
packages/cli/src/daemon/auto-update.tsdist-ui, strict git UI artifact gating, and npm-layout UI gating before pending state/swap.packages/cli/src/migration.tspackages/cli/src/cli.tspackages/cli/src/node-ui-static.tspackages/cli/src/rollback-node-ui.tsbuild:ui; npm slots are packaged-assets check-only.packages/cli/test/auto-update.test.tsdist-uicleanup, legacy package-name refs, missing git/npm UI artifacts, mixed npm package artifacts, and UI build failure before swap.packages/cli/test/migration.test.tspackages/cli/test/node-ui-static.test.tspackages/cli/test/rollback-node-ui.test.tsRELEASE_PROCESS.mddocs/testing/AUTO_UPDATE_LOCAL_TESTING.mdTest plan
pnpm install --frozen-lockfilecompleted successfully.pnpm build:runtimepasses after the latest changes.pnpm --filter @origintrail-official/dkg-node-ui run build:uipasses andpackages/node-ui/dist-ui/index.htmlexists.pnpm --dir packages/cli exec vitest run --config ..\..\vitest.evm-integration.ts test\auto-update.test.ts -t "npm Node UI static bundle|legacy npm UI bundle|Node UI workspace package name|Node UI static build after|git Node UI static bundle is missing|Node UI static build fails"passes 6 focused auto-update tests.pnpm --dir packages/cli exec vitest run --config ..\..\vitest.evm-integration.ts test\migration.test.ts -t "npm-layout slots"passes 2 focused migration npm-layout tests.pnpm --dir packages/cli exec vitest run --config ..\..\vitest.evm-integration.ts test\node-ui-static.test.tspasses 3 helper tests.pnpm --dir packages/cli exec vitest run --config ..\..\vitest.evm-integration.ts test\rollback-node-ui.test.tspasses 4 rollback readiness tests.git diff --check -- packages/cli/src/daemon/auto-update.ts packages/cli/src/node-ui-static.ts packages/cli/src/migration.ts packages/cli/src/cli.ts packages/cli/src/rollback-node-ui.ts packages/cli/test/auto-update.test.ts packages/cli/test/migration.test.ts packages/cli/test/node-ui-static.test.ts packages/cli/test/rollback-node-ui.test.tspasses.EPERMlimitations; broader symlink-based focused migration tests hit the same local setup issue after reaching or creatingreleases/current.