Open
Conversation
Contributor
Author
|
Follow-up pushed in Validation after the follow-up:
Note: I retried |
Contributor
Author
|
Review round 2 follow-up is pushed in Validation after the follow-up:
|
Contributor
Author
|
Review round 3 follow-up is pushed in Validation after this follow-up:
|
Contributor
Author
|
Review round 4 follow-up is pushed in Validation after this follow-up:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChatTurnWriterstate: W4b counts flush synchronously after daemon success, and direct-channel writes record exact, content-bound external markers.DkgChannelPluginto notify the writer only after daemon persist success, retry marker-only failures without replaying daemon writes, track first marker writes before awaiting them, drain marker jobs on shutdown with a bounded wait, preserve returned reply session keys, require legacy route fallbacks to return their real session key before writing a marker, and keep marker migration retries idempotent.Related
Files changed
packages/adapter-openclaw/src/ChatTurnWriter.tspackages/adapter-openclaw/src/DkgChannelPlugin.tspackages/adapter-openclaw/src/DkgNodePlugin.tspackages/adapter-openclaw/src/types.tspackages/adapter-openclaw/test/ChatTurnWriter.test.tspackages/adapter-openclaw/test/dkg-channel.test.tspackages/adapter-openclaw/test/plugin.test.tsTest plan
pnpm --filter @origintrail-official/dkg-adapter-openclaw exec vitest run test/dkg-channel.test.ts -t "marker"-> 9 selected tests passed.pnpm --filter @origintrail-official/dkg-adapter-openclaw exec vitest run test/dkg-channel.test.ts -t "routeInboundMessage fallback"-> 8 selected tests passed.pnpm --filter @origintrail-official/dkg-adapter-openclaw exec vitest run test/ChatTurnWriter.test.ts -t "T83|T105|T97|T103|T102|T90"-> 6 selected tests passed.pnpm --filter @origintrail-official/dkg-adapter-openclaw exec vitest run test/ChatTurnWriter.test.ts test/dkg-channel.test.ts test/dkg-client.test.ts-> 250 tests passed.pnpm --filter @origintrail-official/dkg-adapter-openclaw build-> passed.pnpm --filter @origintrail-official/dkg-adapter-openclaw exec vitest run test/plugin.test.ts -t "memory resolver reads the UI-selected CG"-> passed.pnpm --filter @origintrail-official/dkg exec vitest run test/daemon-openclaw.test.ts-> 84 tests passed; command exited 0 after a trailing Windows path warning.pnpm build:runtime-> passed.git diff --check-> passed with CRLF warnings only.e8b666b6. The remaining red monorepo matrix jobs are unrelated known-debt/spec-gap lanes sampled in network-sim, storage parity/private-store, CLI auth/keystore/autoupdater, and agent DID/workspace-config tests.