fix(dashboard): release microphone when leaving ODS Talk mid-recording - #2959
Open
patil2001 wants to merge 1 commit into
Open
fix(dashboard): release microphone when leaving ODS Talk mid-recording#2959patil2001 wants to merge 1 commit into
patil2001 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Leaving ODS Talk mid-recording aborted the chat stream but never touched the
MediaRecorder: tracks stop only inside itsonstop, which fires solely from the button path. Navigating away kept the microphone live and buffering audio. Unmount cleanup now stops the recorder, releasing capture through the existingonstophandler.AI Assistance
AI-assisted trace of recording teardown paths. The author reviewed the cleanup addition and is responsible for the final diff.
Release Lane
release/2.6.xmainStable hotfix reason:
Changed Surface
Validation
esbuild --loader:.jsx=jsxparse ofODSTalk.jsx- passed.