fix(windows): quote spaced paths in host agent Start-Process args - #2960
Open
patil2001 wants to merge 1 commit into
Open
fix(windows): quote spaced paths in host agent Start-Process args#2960patil2001 wants to merge 1 commit into
patil2001 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows PowerShell 5.1 joins
Start-Process -ArgumentListelements with spaces but no quoting, so any install path containing a space produced a truncated argv for the host agent (C:\Users\Johninstead ofC:\Users\John Smith\...) and python exited instantly while the installer continued green. Agent args containing whitespace are now double-quoted before launch.AI Assistance
AI-assisted review of generated task-script quoting. The author traced the argv split and is responsible for the final diff.
Release Lane
release/2.6.xmainStable hotfix reason:
Changed Surface
Validation
Start-Process -ArgumentListjoining semantics;PSScriptAnalyzer(lint-powershell.yml) will parse-check in CI (no local pwsh).