fix(scripts): create cold-storage target before archiving models - #2979
Open
patil2001 wants to merge 1 commit into
Open
fix(scripts): create cold-storage target before archiving models#2979patil2001 wants to merge 1 commit into
patil2001 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Secure Boot auto-resume unit embedded
${SCRIPT_DIR}unquoted inExecStartandWorkingDirectory, so an install path containing a space produced a unit systemd can't start right when it matters most — after MOK enrollment reboot. The unit also expanded${USER}at generation time, which kills the whole install with "unbound variable" when invoked from a context that doesn't export USER (systemd/cron) — aftermokutil --importqueued but before the one-time password was shown. Paths are now quoted and USER falls back toid -un.Behavior and invariants
AI Assistance
AI-assisted enumeration of generation-context failures. The author reproduced both failure shapes and is responsible for the final diff.
Release Lane
release/2.6.xmainStable hotfix reason:
Changed Surface
Validation
bash -n ods/installers/lib/detection.sh- passed.