fix(compose): honor LLAMA_SERVER_IMAGE override on apple overlay - #2982
Open
patil2001 wants to merge 1 commit into
Open
fix(compose): honor LLAMA_SERVER_IMAGE override on apple overlay#2982patil2001 wants to merge 1 commit into
patil2001 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On multi-GPU NVIDIA installs whose assignment JSON lacks an entry for whisper/comfyui/embeddings, jq's
.gpus[0]?prints the literal stringnull, which phase 03 persists verbatim — compose then rendersdevice_ids: ["null"]anddocker compose upfails container-create withcould not select device "null". The three extractions now fall back to empty, matching how the CLI's own reassign path guards the same reads.AI Assistance
AI-assisted trace from jq output to rendered compose. The author reviewed the guard style used elsewhere and is responsible for the final diff.
Release Lane
release/2.6.xmainStable hotfix reason:
Changed Surface
Validation
bash -n ods/installers/phases/03-features.sh- passed.