fix(installer): harden Secure Boot resume unit quoting and USER lookup - #2985
Open
patil2001 wants to merge 1 commit into
Open
fix(installer): harden Secure Boot resume unit quoting and USER lookup#2985patil2001 wants to merge 1 commit into
patil2001 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ods rollbackcomputed compose flags before restoring, then reused them forup -d. When an update changed stack-shaping values (ODS_MODE, TIER, GPU_BACKEND, enabled extensions), rollback reported success while recreating the abandoned configuration's stack — restored cloud mode still booting local llama-server, or an amd restore without its overlay. Flags are now recomputed from the restored.envbetween restore and restart.Behavior and invariants
downunchangedAI Assistance
AI-assisted control-flow review of cmd_rollback. The author traced the flag lifecycle and is responsible for the final diff.
Release Lane
release/2.6.xmainStable hotfix reason:
Changed Surface
Validation
bash -n ods/ods-cli- passed.