[ДЗ | Dagger 2] - Егор Шкляревский#151
Open
jeghor wants to merge 2 commits intoOtus-Android:masterfrom
Open
Conversation
antonkazakov
suggested changes
Nov 23, 2024
Contributor
antonkazakov
left a comment
antonkazakov
left a comment
There was a problem hiding this comment.
Привет. Оставил несколько коментариев
| class FragmentProducer : Fragment() { | ||
|
|
||
| @Inject | ||
| lateinit var application: Application |
Contributor
There was a problem hiding this comment.
А зачем тебе этот инжект?
| @Module | ||
| object ColorGeneratorModule { | ||
|
|
||
| @Provides |
Contributor
There was a problem hiding this comment.
Это нужно заменить на binds
| @Module | ||
| object ViewModelReceiverModule { | ||
|
|
||
| @Provides |
Contributor
There was a problem hiding this comment.
Тоже можно поменять на binds
Author
There was a problem hiding this comment.
Немного не понимаю как, я же тут из параметров создаю вьюмодель. По мне биндс не подходит
Можете по подробнее описать?
| class FragmentReceiver : Fragment() { | ||
|
|
||
| @Inject | ||
| lateinit var application: Application |
Contributor
There was a problem hiding this comment.
Зачем нужен этот инжект?
| private val context: Context | ||
| class ViewModelReceiver @Inject constructor( | ||
| private val context: Context, | ||
| private val colorFlow: MutableStateFlow<Int> |
Contributor
There was a problem hiding this comment.
Здесь лучше инжектить иммутабельную версию
makzimi
approved these changes
Feb 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.