feat: add support for named FHIR connections in Helm chart#14
Open
mechanik-daniel wants to merge 3 commits intomainfrom
Open
feat: add support for named FHIR connections in Helm chart#14mechanik-daniel wants to merge 3 commits intomainfrom
mechanik-daniel wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for managing named FHIR connections via a Secret-backed
connections.ymlfile in the FUME Helm chart. It introduces a new configuration section that allows users to define FHIR connection details in a YAML file, which is securely mounted into the backend deployment. The implementation includes validation to prevent misconfiguration and updates the documentation to guide users through the new setup.Named FHIR Connections feature:
fhirConnectionssection invalues.yamlto enable, configure the mount path, and provide the YAML content for named FHIR connections. The file is stored in a Kubernetes Secret and mounted into the backend container. (helm/fume/values.yaml,helm/fume/templates/connections-secret.yaml, [1] [2] [3]connections.ymlSecret at the specified path, set theFHIR_CONNECTIONS_FILEenvironment variable automatically, and ensure the deployment is reloaded when the Secret changes. (helm/fume/templates/backend-deployment.yaml, [1] [2]Validation and conflict prevention:
fhirConnections.enabledis true, bothmountPathandyamlare provided, and to ensureenv.FHIR_CONNECTIONS_FILEdoes not conflict with the configured mount path. (helm/fume/templates/_helpers.tpl, helm/fume/templates/_helpers.tplR91-R101)$envvariable is initialized to avoid nil map errors during validation. (helm/fume/templates/_helpers.tpl, helm/fume/templates/_helpers.tplR73)Documentation updates:
helm/fume/README.md, [1] [2]