Fix/v2.1.1#57
Merged
mechanik-daniel merged 6 commits intoOutburn-IL:mainfrom Feb 14, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the FLASH tokenizer/parser to correctly support URL-based slice identifiers inside [...] (e.g., extension[http://... ]) and adds regression tests for the new behavior, along with a patch version bump to v2.1.1.
Changes:
- Update URL tokenization to stop at additional structural delimiters (notably
]) so bracketed URL slices tokenize correctly. - Allow
urltokens as valid slice identifiers in FLASH paths. - Add a new FLASH slice test group covering URL slices (including
InstanceOfas a canonical URL) and bump package version / lockfile.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/test-suite/groups/flash-slices/url-slices-in-brackets.json | Adds test cases validating URL slice syntax and expected FHIR output. |
| test/test-suite/groups/flash-slices/url-slices-in-brackets.fume | New FLASH expression using a URL directly inside slice brackets. |
| test/test-suite/groups/flash-slices/url-slices-in-brackets-instanceof-url.fume | New FLASH expression validating InstanceOf with canonical URL and URL slice usage. |
| src/utils/tokenizer.js | Fixes URL token scanning so URLs terminate on ] (and other structural delimiters). |
| src/parser.js | Allows url tokens to be used as valid slice identifiers in FLASH paths. |
| package.json | Bumps package version to 2.1.1 and updates eslint-plugin-jsdoc. |
| package-lock.json | Updates lockfile to reflect version bump and dependency resolution changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR updates the FLASH tokenizer/parser to correctly support URL-based slice identifiers inside
[...](e.g.,extension[http://... ]) and adds regression tests for the new behavior, along with a patch version bump tov2.1.1.Changes:
]) so bracketed URL slices tokenize correctly.urltokens as valid slice identifiers in FLASH paths.