feat: update library to a Dart package#128
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR transitions internet_connection_checker_plus from a Flutter package setup to a pure Dart package setup, updating dependencies, test tooling, and CI accordingly.
Changes:
- Remove Flutter SDK dependency and switch to
package:test+dart test. - Replace
flutter_lints/Flutter analysis withpackage:lintsanddart analyze. - Clean up Flutter-specific repo artifacts (e.g.,
.metadata) and simplify ignore/config files.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/internet_connection_test.dart | Switch test framework import from Flutter test to package:test. |
| test/internet_check_result_test.dart | Switch test framework import from Flutter test to package:test. |
| test/internet_check_option_test.dart | Switch test framework import from Flutter test to package:test. |
| test/mocks/test_http_client.dart | Minor cleanup (comment removal). |
| pubspec.yaml | Remove Flutter SDK dependency/constraints; add lints + test dev deps; update package description to “pure Dart”. |
| lib/internet_connection_checker_plus.dart | Minor cleanup of import section comments. |
| example/lib/pages/listen_to_stream.dart | Minor import/comment cleanup in Flutter example. |
| example/lib/pages/listen_once.dart | Minor import/comment cleanup in Flutter example. |
| example/lib/pages/custom_uris.dart | Minor import/comment cleanup in Flutter example. |
| example/lib/pages/custom_success_criteria.dart | Minor import/comment cleanup in Flutter example. |
| example/lib/main.dart | Minor import/comment cleanup in Flutter example. |
| analysis_options.yaml | Switch from flutter_lints include to lints/recommended. |
| .metadata | Remove Flutter project metadata file. |
| .gitignore | Simplify ignores to Dart-only entries. |
| .github/workflows/unit_tests.yml | Move CI from Flutter toolchain to Dart toolchain (dart pub get, dart test). |
| .github/workflows/code_quality.yml | Move CI from Flutter toolchain to Dart toolchain (dart format, dart analyze). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.