refactor: lazily initialize singleton instance#133
Closed
OutdatedGuy wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors InternetConnection’s singleton initialization from eager static initialization to a lazy initialization approach, so the instance is created only when first accessed.
Changes:
- Updated
factory InternetConnection()to lazily create and cache the singleton instance. - Replaced the eagerly initialized
static final _instancewith a nullable static backing field.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
139
to
+140
| /// The singleton instance of [InternetConnection]. | ||
| static final _instance = InternetConnection.createInstance(); | ||
| static InternetConnection? _instance; |
Comment on lines
65
to
+71
| /// Returns an instance of [InternetConnection]. | ||
| /// | ||
| /// This is a singleton class, meaning that there is only one instance of it. | ||
| factory InternetConnection() => _instance; | ||
| factory InternetConnection() { | ||
| _instance ??= InternetConnection.createInstance(); | ||
| return _instance!; | ||
| } |
Owner
Author
|
Dart's static and top-level variables are naturally lazy, hence this is useless! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.