Sort output by order provided in opcodes file#1
Open
Makar8000 wants to merge 3 commits intoOverlayPlugin:mainfrom
Open
Sort output by order provided in opcodes file#1Makar8000 wants to merge 3 commits intoOverlayPlugin:mainfrom
Makar8000 wants to merge 3 commits intoOverlayPlugin:mainfrom
Conversation
Contributor
|
I think the more "correct" way to handle this would be to do the initial deserialization to a type that preserves order (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
I'm not familiar with JsonNodes in C# so if there is a cleaner way to do stuff like this:
...do let me know!