[WIP] raidboss: Add new properties to data#906
Draft
valarnin wants to merge 1 commit intoOverlayPlugin:mainfrom
Draft
[WIP] raidboss: Add new properties to data#906valarnin wants to merge 1 commit intoOverlayPlugin:mainfrom
data#906valarnin wants to merge 1 commit intoOverlayPlugin:mainfrom
Conversation
github-actions
bot
added
raidboss
|
I'm going to merge this in my personal branch and help test it. |
|
I can confirm this doesn't crash and the regular triggers work fine. I haven't yet confirmed if modified triggers behave as expected though. |
|
This is working for me, at least with respect to the zoneId. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #626.
As mentioned in the linked issue, there are some properties I've been wanting to add to
datafor a while now. This PR adds those new properties.This is completely untested currently, and I likely won't get around to testing it more or touching it until after week 1 savage prog is done, at the least.
Things that need to be tested:
meId,zoneName,zoneIdproperties get valid datatimelinefunctions work at all, and do they not break the timeline